add deployment settings pointer for concurrency docs #26602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-27esek7ic-elementl.vercel.app Direct link to changed pages: |
gibsondan
reviewed
Dec 19, 2024
| @@ -422,7 +422,7 @@ The concurrency key should match the name that the op/asset is tagged with. For | |||
|
|
|||
| A default concurrency limit can be configured for the instance, for any concurrency keys that do not have an explicit limit set: | |||
|
|
|||
| - **Dagster+**: Use the [Dagster+ UI or the `dagster-cloud` CLI][cloud-deployment-settings] | |||
| - **Dagster+**: Use the deployment settings via the [Dagster+ UI or the `dagster-cloud` CLI][cloud-deployment-settings] | |||
There was a problem hiding this comment.
"Use the deployment settings" reads a little odd to me. Maybe "Edit the concurrency key in deployment settings via the`
There was a problem hiding this comment.
Yeah, this reads better to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Add a pointer that the UI / CLI settings changes are deployment settings
How I Tested These Changes
inspection